Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention epidatpy everywhere as a current client #1550

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Mention epidatpy everywhere as a current client #1550

merged 4 commits into from
Oct 16, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Oct 9, 2024 •
edited
Loading

Summary:

Mention epidatpy everywhere as a current client. Give epidatpy examples. Link to package-specific API key help info.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@nmdefries nmdefries requested a review from dshemetov October 9, 2024 23:00
dshemetov
dshemetov previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested the now-online docs link in a few places, but otherwise looks good 👍 Didn't do a comprehensive search for more links or client mentions, this should be good enough.

docs/api/api_keys.md Outdated Show resolved Hide resolved
docs/api/client_libraries.md Outdated Show resolved Hide resolved
docs/api/covidcast_clients.md Outdated Show resolved Hide resolved
@nmdefries @dshemetov
use epidatpy doc site for links
0d7ae31 
Co-authored-by: Dmitry Shemetov <[email protected]>
@nmdefries @dshemetov
use epidatpy doc site for links
00091df 
Co-authored-by: Dmitry Shemetov <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nmdefries nmdefries requested a review from dshemetov October 16, 2024 19:09
@nmdefries
Copy link
Contributor Author

@dshemetov sorry, can you re-approve? I dismissed your review accidentally.

@nmdefries nmdefries merged commit 8598215 into dev Oct 16, 2024
7 checks passed
@nmdefries nmdefries deleted the ndefries/update-api-keys branch October 16, 2024 20:52
@melange396 melange396 mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmdefries @dshemetov